Remove duplicate bom dependencies #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
force-pushed
the
remove-opentelemetry-bom
branch
from
1a49c9e to
5ab1efc
Compare
jack-berg
commented
Oct 13, 2023
| @@ -20,7 +20,6 @@ dependencies { | |||
|
|
|||
| // OpenTelemetry core | |||
| implementation platform('io.opentelemetry:opentelemetry-bom:1.31.0') | |||
| implementation platform('io.opentelemetry:opentelemetry-bom-alpha:1.31.0-alpha') | |||
There was a problem hiding this comment.
Getting started only used stable components
jack-berg
commented
Oct 13, 2023
| @@ -29,7 +29,6 @@ subprojects { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation platform("io.opentelemetry:opentelemetry-bom:1.30.1") | |||
There was a problem hiding this comment.
The alpha bom below depends on this stable bom.
keegoid-nr
pushed a commit
to keegoid-nr/newrelic-opentelemetry-examples
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should quiet dependabot a bit.